2011/2/24 Becker, VincentX <vincentx.becker at intel.com>: >>From: Maarten Bosmans [mailto:mkbosmans at gmail.com] >>2011/2/23 Becker, VincentX <vincentx.becker at intel.com>: >>> Thanks for your review Maarten. So you suggest to split this into >>several patches (2). One for the outer implementation and the other for >>the inner one. I will try to attend to the irc meeting tomorrow so I can >>catch your remarks in real time. >> >>I'm not sure what you mean by outer and inner implementation. What I >>meant was one patch thats adds the option to log to a file (this patch >>touches all four files) and one patch that does the metadata, >>append_data thing (should only change src/pulsecore/log.c) >> >>Having two clean patches (see my other comments) tomorrow would help >>to keep thing moving in the meeting. > > Hi Maarten, > Here are the 2 patches as you suggested (both patches can be compiled separately). I also integrated one of your remarks, but not all. Like concerning the file naming, as you said it might be a bit too complicated and appending the file or creating a new one might be enough. But it remains a powerful way to debug pulseaudio and it is more direct than using syslog. > I also wrote a module dedicated to log PCM samples, configurable for sinks and/or sources with or without their respective sink inputs/source outputs. I will submit it probably next month. > > Vince But these two patches cannot be appied on top of eachother, as PA_LOG_FILED is added in log.h in both. Also, I would expect the two case PA_LOG_FILED branches to be introduced in the 0001-Add-a-new-log-target-to-a-file-descriptor-in-daemon patch, not the other one. Anyway, I added a link to the meeting page http://pulseaudio.org/wiki/Meetings/2011-02-24 , we'll see where it goes. Maarten
