>-----Original Message----- >From: pulseaudio-discuss-bounces at mail.0pointer.de [mailto:pulseaudio- >discuss-bounces at mail.0pointer.de] On Behalf Of Paul Menzel >Sent: Thursday, February 24, 2011 11:15 PM >To: pulseaudio-discuss at mail.0pointer.de >Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log >feature > >Dear VincentX, > > >please note in the subject what iteration your patch is, e. g. ?[PATCH >1/2 v2]?. See `--subject-prefix` in `git help format-patch`. Ok I will check this. Also I will include an example in the commit message. > >Am Donnerstag, den 24.02.2011, 16:30 +0000 schrieb Becker, VincentX: >> From 55f84afd8575dadba697c746daa61ee07b333c57 Mon Sep 17 00:00:00 2001 >> From: Vincent Becker <vincentx.becker at intel.com> >> Date: Thu, 24 Feb 2011 16:52:05 +0100 >> Subject: [PATCH] Add a new log target to a file descriptor in daemon >> configuration >> Signed-off-by: Vincent Becker <vincentx.becker at intel.com> This >> patches adds the option to log pulseaudio messages into a file >descriptor. > >Could you add that indentation change in a separate patch? It makes it >easier to review in my opinion. It is not necessary though. Uh.. > >[?] > >Could you also document the new option in the manual and add an example >to it? Do the config file templates also need to be updated? How do I update this manual ? I need to do some changes before redelivering the patches and I will check the config file templates as well. Thx. Vincent > > >Thanks, > >Paul --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
