Each user of the exported symbols related to the pwm-lpss driver needs to import the matching namespace. So this can just be done in the header together with the prototypes. This fixes drivers/pinctrl/intel/pinctrl-intel.c which failed to import that namespace before. (However this didn't hurt because the pwm-lpss module namespace isn't used; see the next commit.) Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> --- drivers/pwm/pwm-lpss-pci.c | 2 -- drivers/pwm/pwm-lpss-platform.c | 2 -- include/linux/platform_data/x86/pwm-lpss.h | 7 +++++++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c index f7ece2809e6b..8615c44c1034 100644 --- a/drivers/pwm/pwm-lpss-pci.c +++ b/drivers/pwm/pwm-lpss-pci.c @@ -8,7 +8,6 @@ */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/pci.h> #include <linux/pm_runtime.h> @@ -70,4 +69,3 @@ module_pci_driver(pwm_lpss_driver_pci); MODULE_DESCRIPTION("PWM PCI driver for Intel LPSS"); MODULE_LICENSE("GPL v2"); -MODULE_IMPORT_NS(PWM_LPSS); diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c index 5130238a4567..3de1ab2cff54 100644 --- a/drivers/pwm/pwm-lpss-platform.c +++ b/drivers/pwm/pwm-lpss-platform.c @@ -9,7 +9,6 @@ #include <linux/kernel.h> #include <linux/mod_devicetable.h> -#include <linux/module.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/property.h> @@ -78,5 +77,4 @@ module_platform_driver(pwm_lpss_driver_platform); MODULE_DESCRIPTION("PWM platform driver for Intel LPSS"); MODULE_LICENSE("GPL v2"); -MODULE_IMPORT_NS(PWM_LPSS); MODULE_ALIAS("platform:pwm-lpss"); diff --git a/include/linux/platform_data/x86/pwm-lpss.h b/include/linux/platform_data/x86/pwm-lpss.h index 752c06b47cc8..0a1025f6cd58 100644 --- a/include/linux/platform_data/x86/pwm-lpss.h +++ b/include/linux/platform_data/x86/pwm-lpss.h @@ -4,6 +4,7 @@ #ifndef __PLATFORM_DATA_X86_PWM_LPSS_H #define __PLATFORM_DATA_X86_PWM_LPSS_H +#include <linux/module.h> #include <linux/types.h> struct device; @@ -30,4 +31,10 @@ struct pwm_lpss_boardinfo { struct pwm_chip *devm_pwm_lpss_probe(struct device *dev, void __iomem *base, const struct pwm_lpss_boardinfo *info); +/* + * The above function and the pwm_lpss_boardinfo variables in + * drivers/pwm/pwm-lpss.h are defined in the PWM_LPSS namespace. + */ +MODULE_IMPORT_NS(PWM_LPSS); + #endif /* __PLATFORM_DATA_X86_PWM_LPSS_H */ -- 2.45.2