On Tue, Dec 03, 2024 at 06:16:14PM +0100, Uwe Kleine-König wrote: > Each user of the exported symbols related to the pwm-lpss driver needs > to import the matching namespace. So this can just be done in the header > together with the prototypes. > > This fixes drivers/pinctrl/intel/pinctrl-intel.c which failed to import > that namespace before. (However this didn't hurt because the pwm-lpss > module namespace isn't used; see the next commit.) I disagree on this change, I think it had been discussed already. The header must not provide any module importing features as it effectively diminishes the point of namespace. Any (ab)user can include just a header and be okay with that. Besides that, you should have based this on recent changes in the NS area of the module symbols, i.e. module namespaces needs to be provided as string literals. See last few commits in Linus' tree as of today. -- With Best Regards, Andy Shevchenko
