Re: [PATCH 2/2] pwm: lpss: Define DEFAULT_SYMBOL_NAMESPACE earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 03, 2024 at 06:16:15PM +0100, Uwe Kleine-König wrote:
> DEFAULT_SYMBOL_NAMESPACE must be already defined when <linux/export.h>
> is included. So move the define above the include block.
> 
> With the DEFAULT_SYMBOL_NAMESPACE being defined too late, the exported
> symbols end up in the default namespace. So the modules making use of
> the symbols defined in pwm-lpss.c can import these just fine and just
> import the the PWM_LPSS namespace without any gain.

Documentation disagrees with you. But, you are right, a lurking bug is here as
we need to undef existing define.

> -#define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux