Hi, On 3-Dec-24 1:58 PM, Andy Shevchenko wrote: > On Mon, Dec 2, 2024 at 11:48 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> On 2-Dec-24 7:45 PM, Andy Shevchenko wrote: >>> On Mon, Dec 02, 2024 at 08:34:01PM +0200, Ilpo Järvinen wrote: >>>> On Sat, 16 Nov 2024, Hans de Goede wrote: > > ... > >>>>> +struct atla10_ec_battery_state { >>>>> + u8 status; /* Using ACPI Battery spec status bits */ >>>>> + u8 capacity; /* Percent */ > > Then an obvious remark based on Hans' reply, why are these internal > kernel types and not external ones, i.e. __u8? Because this is not a uapi header? Regards, Hans