Hi Eugene, Thanks a lot for the quick feedback. It will definitely help us speed up the development process. I will commit your suggested fix shortly. For your other suggestion, there is a video device capability PJMEDIA_VID_DEV_CAP_OUTPUT_WINDOW which will allow application to provide their own output window, however it still hasn't been implemented in the video devices. Hopefully we can get this implemented in the near future. Best regards, Ming On Thu, Dec 16, 2010 at 6:42 PM, Eugene Goldfarb <gene.goldfarb at gmail.com> wrote: > Been using pjsip on iphone for a long time now, it's been a great > experience, and ?I've been waiting anxiously to take a peek at the > latest video efforts. > > Finally saw the freshly posted video driver for iPhone. > > There is a slight problem with this implementation: the UI is updated > from a background thread. ?This should not be done - UI updates will > be unpredictable and lagging. ?It's good idea to perform actual image > conversion in the background, though. > > A simple fix is to change line 331 from > [stream->imgView setImage:image]; > > to: > > [stream->imgView performSelectorOnMainThread:@selector(setImage:) > ? ? ? ? ? ? ? ? ? ? ? ? ? withObject:image > ? ? ? ? ? ? ? ? ? ? ? ?waitUntilDone:NO]; > > Another architectural issue is the fact that the video output is added > directly to the main application window - this will need to change in > order for third-party developers to be able to incorporate video into > their own view hierarchy. > > Thank you and keep up the great work! > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >
