conference.c bug?

[fabio.cherchi@xxxxxxxx (Fabio Cherchi)]

Hi Benny et al,

I'm trying to create a conf bridge without the sound device, but even if 
I apply the option PJMEDIA_CONF_NO_DEVICE to the pjmedia_conf_create() 
callback, I get the following message

18:08:28.657   conference.c  Sound device successfully created for port 0

I've checked the conference.c code in the following section:

[...]
static pj_status_t create_sound_port( pj_pool_t *pool,
                                      pjmedia_conf *conf )
{
    struct conf_port *conf_port;
    pj_str_t name = { "Master/sound", 12 };
    pj_status_t status;

    status = create_pasv_port(conf, pool, &name, NULL, &conf_port);
    if (status != PJ_SUCCESS)
        return status;

    /* Create sound device port: */
    *if ((conf->options & PJMEDIA_CONF_NO_DEVICE) == 0) {*
        pjmedia_aud_stream *strm;
        pjmedia_aud_param param;
[...]

    }

     /* Add the port to the bridge */
    conf->ports[0] = conf_port;
    conf->port_cnt++;

    PJ_LOG(5,(THIS_FILE, "Sound device successfully created for port 0"));
    return PJ_SUCCESS;
}

the bold condition should skip the sound port creation, but why the last 
lines are outside the "if"?
(I'm using pjproject 1.1)

Thanks,
Fabio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20090505/81cbbe26/attachment.html>