conference.c bug?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 5, 2009 at 9:19 PM, Fabio Cherchi <fabio.cherchi at yahoo.it>wrote:

>  Hi Benny et al,
>
> I'm trying to create a conf bridge without the sound device, but even if I
> apply the option PJMEDIA_CONF_NO_DEVICE to the pjmedia_conf_create()
> callback, I get the following message
>
> 18:08:28.657   conference.c  Sound device successfully created for port 0
>
>
Yeah it's a wrong message, good catch. Just fixed this in r2696.

thanks
 Benny




> I've checked the conference.c code in the following section:
>
> [...]
> static pj_status_t create_sound_port( pj_pool_t *pool,
>                                       pjmedia_conf *conf )
> {
>     struct conf_port *conf_port;
>     pj_str_t name = { "Master/sound", 12 };
>     pj_status_t status;
>
>     status = create_pasv_port(conf, pool, &name, NULL, &conf_port);
>     if (status != PJ_SUCCESS)
>         return status;
>
>     /* Create sound device port: */
>     *if ((conf->options & PJMEDIA_CONF_NO_DEVICE) == 0) {*
>         pjmedia_aud_stream *strm;
>         pjmedia_aud_param param;
> [...]
>
>     }
>
>      /* Add the port to the bridge */
>     conf->ports[0] = conf_port;
>     conf->port_cnt++;
>
>     PJ_LOG(5,(THIS_FILE, "Sound device successfully created for port 0"));
>     return PJ_SUCCESS;
> }
>
> the bold condition should skip the sound port creation, but why the last
> lines are outside the "if"?
> (I'm using pjproject 1.1)
>
> Thanks,
> Fabio
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20090512/a2cb52e2/attachment-0001.html>


[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux