Hi Benny I suppose it would depend on what you are playing. My voice recordings sound just fine looping in this manner. But I do get your point. I think the only way to satisfy everyone would be to add a second callback function, or add another argument to the current callback function and just call it at two points: 1. At EOF, even if playback is not done. 2. If not looping, when playback is complete (all frames have been sent out) I'll try to whip up a new patch as soon as possible. Mike Benny Prijono wrote: > Thanks for the patch, Mike. > > There is a problem though (or so I think). With the patch, the > default behavior has changed to loop the playback instead of playing > it once, which is fine, as I don't think people will object that > much and this is consistent with the WAV player default behavior. > > But with the new callback approach, the player won't be able to > smoothly play the buffer in a loop, as everytime end-of-buffer > condition is reached, the player will insert silence at the end of a > frame. In other words, to smoothly playback a buffer in a loop, one > has to make the buffer size equal to multiple frame size, which is > difficult IMO. > > Thinking about the original problem, I'm wondering if simply > bzero-ing the remaining frame after EOF is reached will solve the > problem (I think so!). > > cheers, > -benny > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > -- Michael Broughton, Advanis Unintended Recipient & Unauthorized Use of E-Mail: This message and attachments may contain confidential or privileged information that is intended only for the named recipient of this e-mail. Any unauthorized use or distribution is not permitted. If you have received this e-mail in error, deleting the e-mail and notifying the sender would be appreciated. Thank you.
