On 7/19/07, tedd <tedd@xxxxxxxxxxxx> wrote:
At 2:24 PM +0200 7/18/07, Olav Mørkrid wrote: >consider the following statement: > >$language = >isset($_SERVER["HTTP_ACCEPT_LANGUAGE"]) && >$_SERVER["HTTP_ACCEPT_LANGUAGE"] != "" ? >$_SERVER["HTTP_ACCEPT_LANGUAGE"] : "*"; > >when using strings in arrays that may be non-existing or empty, you >have to repeat the reference *three* times, which gets excessive and >unreadable. > >is there any way to only have to write >$_SERVER["HTTP_ACCEPT_LANGUAGE"] only once? > >i know it's possible to supress "is not set" with @, but that just >seems wrong in case there really is an error in the statement. > >i love php, but this is one of my pet peeves. Olav: Mine too. But, Rasmus gave me this: $action = isset($_GET['action']) ? $_GET['action'] : null; Which could be translated to: $language = isset ($_SERVER["HTTP_ACCEPT_LANGUAGE"]) ? ($_SERVER["HTTP_ACCEPT_LANGUAGE"]) : "*"; I think that might help. Anyone see a problem with it? Cheers, tedd --
Yes,what if the key does exists, but is empty? Then it should fallback to the default value, which is exactly what the OP script did, and what yours does too when you add != "" statement, or empty(). Tijnema -- Vote for PHP Color Coding in Gmail! -> http://gpcc.tijnema.info -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
