> On Mon, 2014-09-29 at 14:39 +0100, David Woodhouse wrote
>> Patches 1, 2 and 4 aren't changed from what's in my api4.0 branch, are
>> they?
>
> They are identical to the ones I've sent before, so they should be the
> same.
Ok. Now pushed to master.
>> For the string ownership thing I think we're almost there, and the Java
>> bits seem to be working. We do need to fix gnutls_get_cert_details()
>> which currently returns an allocated string for the caller to free.
>
> You could provide a function for the caller to use to free it.
That requires a user of the library to use it. If we let them pass in an
optional malloc function of their own then they can happily just not
bother.
>> Finally ? on your last patch, you've made some changes to translated
>> strings:
>> - perror(_("UDP (DTLS) connect:\n"));
>> + vpn_progress(vpninfo, PRG_ERR, _("UDP (DTLS) connect: %s\n"),
>> strerror(errno));
>> It'd be really useful if you could preserve the existing translations by
>> adding the ' %s' to the relevant msgstr entries, please.
>
> Isn't that automatically generated with update-po?
No, because it's just a different string as far as the tools are
concerned. But *we* know that we can just add ' %s' between the colon and
the newline at the end of the string, and the translated strings are
equivalent to what was happening before.
--
dwmw2
