On Tue, Aug 26, 2014 at 3:29 PM, David Woodhouse <dwmw2 at infradead.org> wrote: >> So you suggest adding an openconnect_set_user_free(), which will be >> used by openconnect_set_hostname() and friends? I don't like it much, >> but it requires less changes and it would work too. > That's what I was thinking, yes. It's probably the same number of > changes as if you do it in your client, but just in a slightly more > enumerable and future-proof fashion. > But now I'm half-way to talking myself into just bumping the soname and > having *all* functions take 'const char *' :) I've tried to implement that, and the tricky part is the auth form processing. There the openconnect_strdup() has a clear advantage. It is much simpler. Without it, the changes required become quite complicated.
