On Fri, 2014-09-26 at 11:44 +0100, David Woodhouse wrote:
> > >> - if (ret == 0x2331) {
> > >> - /* This is what cmd.exe returns for unrecognised commands */
> > > That made some sense...
> > >
> > >> if (ret) {
> > >> + /* This is what cmd.exe returns for unrecognised commands */
> > > ... but this doesn't. For a start we're not using cmd.exe any more...
> > > and you seem to be suggesting that *all* values other than -1 mean that
> > > it was an unrecognised command :)
> >
> > Indeed. Do you want an updated patch?
>
> Please. If canyou can manage the FormatMessage thing too (we have other
> potential users for it especially in tun-win32.c) that would be much
> appreciated. I'm now working on tidying up the rest of the stuff in my
> 'api4.0' branch to get it pushed to master.
I've gave up with FormatString and simply print GetLastError. The patch
set is attached, and it includes a 5th patch to avoid perror().
regards,
Nikos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-windows-types-and-return-codes-for-socket-errors.patch
Type: text/x-patch
Size: 3476 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140926/8867e687/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-use-recv-and-closesocket-on-the-cmd_fd-on-windows.patch
Type: text/x-patch
Size: 1544 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140926/8867e687/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-use-CreateProcess-instead-of-system-to-run-scripts.patch
Type: text/x-patch
Size: 2810 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140926/8867e687/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-define-_GNU_SOURCE-to-get-asprintf-s-definition-in-m.patch
Type: text/x-patch
Size: 797 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140926/8867e687/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-increase-the-verbosity-of-DTLS-timeout-message-and-a.patch
Type: text/x-patch
Size: 1836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140926/8867e687/attachment-0009.bin>
