On Fri, 2014-09-26 at 20:48 +0200, Nikos Mavrogiannopoulos wrote:
>
> I've gave up with FormatString and simply print GetLastError. The
> patch
> set is attached, and it includes a 5th patch to avoid perror().
Patches 1, 2 and 4 aren't changed from what's in my api4.0 branch, are
they?
For the string ownership thing I think we're almost there, and the Java
bits seem to be working. We do need to fix gnutls_get_cert_details()
which currently returns an allocated string for the caller to free. I
suspect we should just cache it in the vpninfo struct and free it later
(or the next time the function is called), rather than giving the caller
any way to free it individually?
I think we should also be auditing all usage of free() vs. gnutls_free()
for similar reasons, shouldn't we? If libopenconnect and libgnutls are
running with different C runtimes, we'll have problems there too?
Finally ? on your last patch, you've made some changes to translated
strings:
- perror(_("UDP (DTLS) connect:\n"));
+ vpn_progress(vpninfo, PRG_ERR, _("UDP (DTLS) connect: %s\n"), strerror(errno));
It'd be really useful if you could preserve the existing translations by
adding the ' %s' to the relevant msgstr entries, please.
--
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140929/eb8022e3/attachment.bin>
