[NNTPCACHE] newshound SEGVs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I found that newshound SEGVs when populating the cache on RHL 7 systems
(well glibc 2.x specifically anyway). Here's the fix:

--- newshound.c~	Wed Jul 29 16:14:31 1998
+++ newshound.c	Mon Mar 25 00:55:20 2002
@@ -153,9 +153,12 @@
         else
           printf("NH  :> %s or %s is cached\n", tmp, xtmp);
      }
-   fclose(cp);
-   fclose(cp_h);
-   fclose(cp_x);
+   if (cp)
+       fclose(cp);
+   if (cp_h)
+       fclose(cp_h);
+   if (cp_x)
+       fclose(cp_x);
    return result;
   }


Entirely separately, in nntpcache.servers-dist, I saw some configs had a
very high Group timeout - 2 days. I would have thought this would greatly
confuse clients? Or do clients normally rely on xover anyway? Or does this
assume something like newshound is populating the cache in any case, so the
"group" article count will be pretty accurate really?

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine

_______________________________________________
NNTPCache-users mailing list
NNTPCache-users@nntpcache.org
http://www.nntpcache.org/cgi-bin/mailman/listinfo/nntpcache-users

[Index of Archives]     [Yosemite]     [Yosemite Campsites]     [Bugtraq]     [Linux]     [Trn]

Powered by Linux