On Wed, Apr 25, 2007 at 01:07:32PM +0530, Ashok kumar wrote: > On 4/25/07, Greg KH <greg@xxxxxxxxx> wrote: > > > > On Tue, Apr 24, 2007 at 03:39:38PM +0530, Ashok kumar wrote: > > > Hi, > > > > > > i have updated sysfs test patch. i have done changes to write some > > sysfs > > > attribute which was not available in the original patch. The original > > patch > > > is > > > > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/gregkh/sysfs-test.patch > > > > > > My Request: > > > ---------------- > > > please comment on my changes, and suggest me what else i can do on > > this. > > > > What are your changes trying to do? The new functions you create are > > not being called. > > > this is for your kind reference,in case, you have not noticed this line > > Here i setting the permission to write > > - .attr = { .name = __stringify(_name), .mode = 0444, .owner = THIS_MODULE > }, \ > + .attr = { .name = __stringify(_name), .mode = 0644, .owner = THIS_MODULE > }, \ > > Here i am calling the newly added function. > + .store = _type##_store, \ > } > > am i right. Greg? Ah, yes, sorry, I missed that. thanks, greg k-h -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx Please read the FAQ at http://kernelnewbies.org/FAQ
