On 4/25/07, Greg KH <greg@xxxxxxxxx> wrote:
On Tue, Apr 24, 2007 at 03:39:38PM +0530, Ashok kumar wrote:
> Hi,
>
> i have updated sysfs test patch. i have done changes to write some sysfs
> attribute which was not available in the original patch. The original patch
> is
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/gregkh/sysfs-test.patch
>
> My Request:
> ----------------
> please comment on my changes, and suggest me what else i can do on this.
What are your changes trying to do? The new functions you create are
not being called.
this is for your kind reference,in case, you have not noticed this line
Here i setting the permission to write
- .attr = { .name = __stringify(_name), .mode = 0444, .owner = THIS_MODULE }, \
+ .attr = { .name = __stringify(_name), .mode = 0644, .owner = THIS_MODULE }, \
+ .attr = { .name = __stringify(_name), .mode = 0644, .owner = THIS_MODULE }, \
Here i am calling the newly added function.
+ .store = _type##_store, \
}
+ .store = _type##_store, \
}
am i right. Greg?
i tested this patch, it is saving the value to corresponding variable, and displaying newly set variable value, when issuing command "# cat a".
> doubt:
> --------
> i am not able to understand the lines of the original patch, which are
> commented with "#if 0 ... #endif". it would be great, if anyone can give
> some explanation on those lines.
Note, this original module is something I use for testing out various
sysfs and kobject functionality as well as testing ideas for future
things. That is why some of the code is commented out, it does
different things and the whole code is used for different uses at times.
It would be great if you could take the ideas here and make up a real
sysfs/kobject "regression test" module that would exercise various
portions of the codebase.
i will try to do this. i sent this mail to make sure that whether i am doing correctly or not. Because this is the first patch, i sent.
thanks
Ashok
thanks,
greg k-h
