On Tue, Apr 24, 2007 at 03:39:38PM +0530, Ashok kumar wrote: > Hi, > > i have updated sysfs test patch. i have done changes to write some sysfs > attribute which was not available in the original patch. The original patch > is > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/gregkh/sysfs-test.patch > > My Request: > ---------------- > please comment on my changes, and suggest me what else i can do on this. What are your changes trying to do? The new functions you create are not being called. > doubt: > -------- > i am not able to understand the lines of the original patch, which are > commented with "#if 0 ... #endif". it would be great, if anyone can give > some explanation on those lines. Note, this original module is something I use for testing out various sysfs and kobject functionality as well as testing ideas for future things. That is why some of the code is commented out, it does different things and the whole code is used for different uses at times. It would be great if you could take the ideas here and make up a real sysfs/kobject "regression test" module that would exercise various portions of the codebase. thanks, greg k-h -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx Please read the FAQ at http://kernelnewbies.org/FAQ
