On Wed, Sep 28, 2022 at 11:27:09PM +0200, Florian Westphal wrote: > Phil Sutter <phil@xxxxxx> wrote: > > On Wed, Sep 28, 2022 at 07:57:23PM +0200, Florian Westphal wrote: > > > Phil Sutter <phil@xxxxxx> wrote: > > > > The function nft_meta_set_to_target() would always bail since nothing > > > > sets 'sreg->meta_sreg.set' to true. This is obvious, as the immediate > > > > expression "filling" the source register does not indicate its purpose. > > > > > > Hmm, is there a missing test case? I did not see any failures. > > > > extensions/libxt_TRACE.t was failing if I called iptables-test.py with > > '-n' option. > > Argh, I only tested classic :-( Same here! Making nft changes and forgetting to run the testsuite in nft mode is a classic. :) I guess we need a button to run them all at once. Cheers, Phil
