Re: [iptables PATCH] nft: Fix meta statement parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> The function nft_meta_set_to_target() would always bail since nothing
> sets 'sreg->meta_sreg.set' to true. This is obvious, as the immediate
> expression "filling" the source register does not indicate its purpose.

Hmm, is there a missing test case?  I did not see any failures.

> The whole source register purpose storing in meta_sreg seems to be
> pointless, so drop it altogether.

Yes; from iptables perspective a 'meta set' operation has to be mapped
to a target, so there is no need to store this for subsequent
consumption.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux