On Wed, Sep 28, 2022 at 07:57:23PM +0200, Florian Westphal wrote: > Phil Sutter <phil@xxxxxx> wrote: > > The function nft_meta_set_to_target() would always bail since nothing > > sets 'sreg->meta_sreg.set' to true. This is obvious, as the immediate > > expression "filling" the source register does not indicate its purpose. > > Hmm, is there a missing test case? I did not see any failures. extensions/libxt_TRACE.t was failing if I called iptables-test.py with '-n' option. > > The whole source register purpose storing in meta_sreg seems to be > > pointless, so drop it altogether. > > Yes; from iptables perspective a 'meta set' operation has to be mapped > to a target, so there is no need to store this for subsequent > consumption. OK, cool. I'll push this all upstream now. :) Thanks, Phil
