On Mon, 18 May 2015, James Hogan wrote: > >> + if (!(entrylo0 & 1) && (entryhi & 0xff) != asid) > > > > Hmm, it looks like r3k_dump_tlb.c will need a similar update. I suggest > > Yes, quite possibly. Would you be happy to test such a patch (assuming > you have r3000 hardware available)? Patch 1 should allow the code to be > easily triggered. I'll test the change when you have it, no problem with that. > > using _PAGE_GLOBAL and ASID_MASK rather than hardcoded 1 and 0xff. > > Yeh, as you mentioned these describe the PTE rather than what goes in > EntryLo. Perhaps it makes sense to have a few more TLB dependent > definitions in mipsregs.h (patch 7 already adds a couple for RI/XI bits). I think so. Hardcoded magic values are a pain to track down when you need to do so. Will you be able to add MIPS_ENTRYLO_G and R3K_ENTRYLO_G, etc. macros then please? I think you can reorder all mipsregs.h changes ahead of the series as a single patch. Thanks, Maciej
