Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

John W. Linville wrote:

This patch, ported from OpenWRT SVN, defines pcibios_map_irq() and
pcibios_plat_dev_init() for the BCM47xx platform.

It fixes the regression introduced by commit
aab547ce0d1493d400b6468c521a0137cd8c1edf.

Did you read this part?

I usually comment on the patches regardless of such stuff. Maybe I shoudn't have this time in order to not take the blame for the patch bot being merged...

+	if (err) {
+		printk(KERN_ALERT "PCI: Failed to init device %s\n",
+		       pci_name(dev));
+	}
  Unneeded {}...

This is petty bullshit...

  No, just style nitpicking. :-)

Is there a real reason why this hasn't been merged?

  This question is not to me.

John

WBR, Sergei




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux