Re: [PATCH 1/6] [MIPS] BCM47xx: Add platform specific PCI code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 25, 2008 at 02:14:22AM +0400, Sergei Shtylyov wrote:
> Aurelien Jarno wrote:
>
>> This patch, ported from OpenWRT SVN, defines pcibios_map_irq() and
>> pcibios_plat_dev_init() for the BCM47xx platform.
>>
>> It fixes the regression introduced by commit
>> aab547ce0d1493d400b6468c521a0137cd8c1edf.

Did you read this part?

>> +	/* IRQ-0 and IRQ-1 are software interrupts. */
>> +	WARN_ON((res == 0) || (res == 1));
>>   
>
>   Unneeded ()...

Pffttt...

>> +	if (err) {
>> +		printk(KERN_ALERT "PCI: Failed to init device %s\n",
>> +		       pci_name(dev));
>> +	}
>>   
>
>   Unneeded {}...

This is petty bullshit...

Is there a real reason why this hasn't been merged?

John
-- 
John W. Linville		Linux should be at the core
linville@xxxxxxxxxxxxx			of your literate lifestyle.


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux