On Thursday 25 September 2008 00:14:22 Sergei Shtylyov wrote:
> > + WARN_ON((res == 0) || (res == 1));
>
> Unneeded ()...
> > + err = ssb_pcibios_plat_dev_init(dev);
> > + if (err) {
> > + printk(KERN_ALERT "PCI: Failed to init device %s\n",
> > + pci_name(dev));
> > + }
> >
>
> Unneeded {}...
You must me kidding.
Get this freaking regression fix upstream, please.
We're not going to respin it to fix trivial taste issues.
(The above code is _perfectly_ fine and doesn't violate any rule).
--
Greetings Michael.
