On Thu, Sep 25, 2008 at 02:14:22AM +0400, Sergei Shtylyov wrote:
>> + res = ssb_pcibios_map_irq(dev, slot, pin);
>> + if (res < 0) {
>> + printk(KERN_ALERT "PCI: Failed to map IRQ of device %s\n",
>> + dev->dev.bus_id);
>> + return 0;
>> + }
>> + /* IRQ-0 and IRQ-1 are software interrupts. */
>> + WARN_ON((res == 0) || (res == 1));
>>
>
> Unneeded ()...
My rule of thumb for the use of parenthesis is that the reader of a piece
of code should not have to know much about operator precendence, so the
occasional avoidable parenthesis if it serves readability.
Ralf
