On 3/27/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
On Mon, 26 Mar 2007 18:07:21 +0200, "Franck Bui-Huu" <vagabon.xyz@xxxxxxxxx> wrote: > ok, I suppose a warning is fine. What about this patch on top of the patchset ? > > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index 3ec0c12..b886945 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -627,7 +627,12 @@ ifdef CONFIG_64BIT > endif > > ifeq ($(KBUILD_SYM32), y) > - cflags-y += -msym32 -DKBUILD_64BIT_SYM32 > + ifeq ($(call cc-option-yn,-msym32), y) > + cflags-y += -msym32 -DKBUILD_64BIT_SYM32 > + else > + $(warning '-msym32' option is not supported by your compiler. \ > + You should use a new one to get best result) > + endif > endif > endif Well, I feel even a warning is intrusive, while it is not necessary optimization.
OK, I'll remove it. thanks -- Franck