Hi Atsushi,
On 3/26/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
One thing I noticed recently: Your patchset dropped gcc test for
availability of -msym32, so may not work with gcc 3.x.
I suspect you're asking why I did not do this:
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 3ec0c12..b0d8240 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -627,7 +627,7 @@ ifdef CONFIG_64BIT
endif
ifeq ($(KBUILD_SYM32), y)
- cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+ cflags-y += $(call cc-option,-msym32) -DKBUILD_64BIT_SYM32
endif
endif
I remove the call to cc-option because this function removes
_silently_ '-msym32' option if it's not supported by the compiler. IOW
it's really not what we want.
IIRC I haven't found an other function like 'cc-option-strict' which
makes a compilation error in case.
So I assumed that the compiler will complain if it doesn't understand
this option. But it may be incorrect. If so I can add an error message
in Kbuild or add a new Kbuild helper. But I'd like to understand
what's wrong with it before.
Thanks
--
Franck
