Franck Bui-Huu wrote: > Hi Atsushi, > > On 3/26/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote: > >One thing I noticed recently: Your patchset dropped gcc test for > >availability of -msym32, so may not work with gcc 3.x. > > > > I suspect you're asking why I did not do this: > > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index 3ec0c12..b0d8240 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -627,7 +627,7 @@ ifdef CONFIG_64BIT > endif > > ifeq ($(KBUILD_SYM32), y) > - cflags-y += -msym32 -DKBUILD_64BIT_SYM32 > + cflags-y += $(call cc-option,-msym32) -DKBUILD_64BIT_SYM32 > endif > endif > > I remove the call to cc-option because this function removes > _silently_ '-msym32' option if it's not supported by the compiler. IOW > it's really not what we want. It is _exactly_ what we want. -msym32 is always an optional optimization. Thiemo
