Re: [PATCH]: Remove CONFIG_BUILD_ELF64 entirely

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/26/07, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
I think dropping gcc 3.x support for 64-bit kernel is not what we
wanted.  And -msym32 is just an optimization and kernel should be
buildable without it.  So "remove -msym32 silently" is not so bad, I
suppose.

"If you used newer compiler, you can get better result" is natural
thing, isn't it? ;)

ok, I suppose a warning is fine. What about this patch on top of the patchset ?

diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 3ec0c12..b886945 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -627,7 +627,12 @@ ifdef CONFIG_64BIT
  endif

  ifeq ($(KBUILD_SYM32), y)
-    cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+    ifeq ($(call cc-option-yn,-msym32), y)
+      cflags-y += -msym32 -DKBUILD_64BIT_SYM32
+    else
+      $(warning '-msym32' option is not supported by your compiler. \
+               You should use a new one to get best result)
+    endif
  endif
endif
--
              Franck


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux