Re: [PATCH] hwmon: (it87) Add support for IT8781F, IT8782F, IT8783E/F

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jean,

Am 26.03.2012 um 19:01 schrieb Jean Delvare:
> [..]
>> If actually it is the job of the module to do such calculations, I would offer to create an it87 patch for IT8783 fixing this - analog to an existing module with a similar behavior (if you know one).
> 
> You assume that the PECI value always refers to the CPU. I do not think
> this is true, other parts (e.g. north bridge) could report their
> temperature through PECI as well.
> 
> And if it is the CPU temperature, we already have the coretemp driver
> providing the same information, so there's little point in implementing
> the same in it87. The only benefit of handling PECI sensors in it87 and
> the like would be so that they can be used as sources for automatic fan
> speed control, but if the chip itself has no idea about the absolute
> value of the temperature then I doubt it can use it for automatic fan
> speed control.
> 
Yes, with the coretemp driver even both core temperatures are displayed correctly. So I agree, it's nonsense to implement our special design into the generic driver  ;-)

Björn


_______________________________________________
lm-sensors mailing list
lm-sensors@xxxxxxxxxxxxxx
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux