On 12/06/2018 07:37 AM, Petr Mladek wrote: > On Thu 2018-12-06 11:15:55, Petr Mladek wrote: >> On Thu 2018-12-06 10:32:00, Miroslav Benes wrote: >>> >>>>> I don't have many code comments as the changes appear to safely and >>>>> correctly do what the say. (We are at v14 after all :) I mainly >>>>> compared the text and comments to the implementation and noted typos >>>>> (marked by substitution s/old/new) and awkward wordings (marked by >>>>> "re-wording suggestion"). That said, I ack'd each patch as I wouldn't >>>>> want these to hold up the patchset. >>>> >>>> Thanks a lot both you and Miroslav for the review. >>>> >>>> I'll give it some more days before I prepare v15. I wonder if Josh >>>> could find some cycle to look at it at least from the top level. >>> >>> For what is worth, I'm fine with all the changes Joe proposed and you can >>> preserve my acks there. >> >> We need enough time for bikeshedding about comments and documentation. >> I need some time to recover. And I still hope that Josh can give it >> a spin. > > Please, forget the above paragraph. I did not get Mirek's one correctly. > I understood it as "Why do we need to wait? You have two acks. > Jump on it and send us v15 immediately." > No worries :) I usually interpret language bikeshedding as an indication that the code is just about done. BTW, I think Josh will be back online next week, as he is out of the office this week. -- Joe
