On Wed 2018-12-05 15:49:14, Joe Lawrence wrote: > On 11/29/2018 04:44 AM, Petr Mladek wrote: > > The atomic replace allows to create cumulative patches. They > > are useful when you maintain many livepatches and want to remove > > one that is lower on the stack. In addition it is very useful when > > more patches touch the same function and there are dependencies > > between them. > > > > Changes against v13: > > > > + Add custom kobj_alive flag to reliably handle kobj state. [Miroslav] > > > > Aside: I don't suppose that this could ever be folded into the kobject > code/data structure itself? This seems like a common problem that > kobj-users will need to solve like this. I am afraid that it does not have much chance to get solved in kobject. They are not designed to be used in static objets and there is pushback against this usecase. > I don't have many code comments as the changes appear to safely and > correctly do what the say. (We are at v14 after all :) I mainly > compared the text and comments to the implementation and noted typos > (marked by substitution s/old/new) and awkward wordings (marked by > "re-wording suggestion"). That said, I ack'd each patch as I wouldn't > want these to hold up the patchset. Thanks a lot both you and Miroslav for the review. I'll give it some more days before I prepare v15. I wonder if Josh could find some cycle to look at it at least from the top level. Best Regards, Petr
