在 2023/9/30 2:34, Dan Williams 写道:
Shiyang Ruan wrote:
在 2023/9/29 1:13, Darrick J. Wong 写道:
On Thu, Sep 28, 2023 at 09:20:52AM -0700, Andrew Morton wrote:
On Thu, 28 Sep 2023 16:44:00 +0800 Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote:
But please pick the following patch[1] as well, which fixes failures of
xfs55[0-2] cases.
[1]
https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.fnst@xxxxxxxxxxx
I guess I can take that xfs patch, as it fixes a DAX patch. I hope the xfs team
are watching.
But
a) I'm not subscribed to linux-xfs and
b) the changelog fails to describe the userspace-visible effects of
the bug, so I (and others) are unable to determine which kernel
versions should be patched.
Please update that changelog and resend?
That's a purely xfs patch anyways. The correct maintainer is Chandan,
not Andrew.
/me notes that post-reorg, patch authors need to ask the release manager
(Chandan) directly to merge their patches after they've gone through
review. Pull requests of signed tags are encouraged strongly.
Shiyang, could you please send Chandan pull requests with /all/ the
relevant pmem patches incorporated? I think that's one PR for the
"xfs: correct calculation for agend and blockcount" for 6.6; and a
second PR with all the non-bugfix stuff (PRE_REMOVE and whatnot) for
6.7.
OK. Though I don't know how to send the PR by email, I have sent a list
of the patches and added description for each one.
If you want I can create a signed pull request from a git.kernel.org
tree.
Where is that list of patches? I see v15 of preremove.
Sorry, I sent the list below to Chandan, didn't cc the maillist because
it's just a rough list rather than a PR:
1. subject: [v3] xfs: correct calculation for agend and blockcount
url:
https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.fnst@xxxxxxxxxxx/
note: This one is a fix patch for commit: 5cf32f63b0f4 ("xfs: fix
the calculation for "end" and "length"").
It can solve the fail of xfs/55[0-2]: the programs
accessing the DAX file may not be notified as expected, because the
length always 1 block less than actual. Then this patch fixes this.
2. subject: [v15] mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind
url:
https://lore.kernel.org/linux-xfs/20230928103227.250550-1-ruansy.fnst@xxxxxxxxxxx/T/#u
note: This is a feature patch. It handles the pre-remove event
of DAX device, by notifying kernel/user space before actually removing.
It has been picked by Andrew in his mm-hotfixes-unstable. I
am not sure whether you or he will merge this one.
3. subject: [v1] xfs: drop experimental warning for FSDAX
url:
https://lore.kernel.org/linux-xfs/20230915063854.1784918-1-ruansy.fnst@xxxxxxxxxxx/
note: With the patches mentioned above, I did a lot of tests,
including xfstests and blackbox tests, the FSDAX function looks good
now. So I think the experimental warning could be dropped.
--
Thanks,
Ruan.
