On Wed, 27 Sep 2023 13:01:25 +0530 Chandan Babu R <chandanbabu@xxxxxxxxxx> wrote: > > > 在 2023/9/27 13:17, Shiyang Ruan 写道: > > > > 在 2023/9/27 11:38, Chandan Babu R 写道: > >> On Tue, Sep 26, 2023 at 06:46:32 PM -0700, Darrick J. Wong wrote: > >>> On Wed, Sep 27, 2023 at 11:18:42AM +1000, Dave Chinner wrote: > >>>> On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: > >>>>> On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: > >>>>>> Hi, > >>>>>> > >>>>>> Any comments? > >>>>> > >>>>> I notice that xfs/55[0-2] still fail on my fakepmem machine: > >>>>> > >>>>> --- /tmp/fstests/tests/xfs/550.out 2023-09-23 > >>>>> 09:40:47.839521305 -0700 > >>>>> +++ /var/tmp/fstests/xfs/550.out.bad 2023-09-24 > >>>>> 20:00:23.400000000 -0700 > >>>>> @@ -3,7 +3,6 @@ Format and mount > >>>>> Create the original files > >>>>> Inject memory failure (1 page) > >>>>> Inject poison... > >>>>> -Process is killed by signal: 7 > >>>>> Inject memory failure (2 pages) > >>>>> Inject poison... > >>>>> -Process is killed by signal: 7 > >>>>> +Memory failure didn't kill the process > >>>>> > >>>>> (yes, rmap is enabled) > >>>> > >>>> Yes, I see the same failures, too. I've just been ignoring them > >>>> because I thought that all the memory failure code was still not > >>>> complete.... > >>> > >>> Oh, I bet we were supposed to have merged this > >>> > >>> https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.fnst@xxxxxxxxxxx/ > > FYI, this one is in Andrew's mm-unstable tree: > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-unstable&id=ff048e3e2d167927634a45f4f424338411a1c4e6 I'll move this into mm-hotfixes so it gets merged into mainline during this -rc cycle. Should it be backported into earlier kernels, via a cc:stable? If so, are we able to identify a Fixes: target? > > >>> > >>> to complete the pmem media failure handling code. Should we (by which I > >>> mostly mean Shiyang) ask Chandan to merge these two patches for 6.7? > >>> > >> > >> I can add this patch into XFS tree for 6.7. But I will need Acks > >> from Andrew > >> Morton and Dan Williams. > > To clarify further, I will need Acked-By for the patch at > https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.fnst@xxxxxxxxxxx/ That would be nice.
