Re: [PATCH] fs: xfs: Change return type to vm_fault_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 16, 2018 at 04:23:53AM -0700, Christoph Hellwig wrote:
> On Mon, Apr 16, 2018 at 04:14:23AM -0700, Matthew Wilcox wrote:
> > That's an unreasonable request.  It would (usually) require writing more
> > code to convert errnos into VM_FAULT returns.  And that code would get
> > precisely zero testing upstream because the next commit would come along
> > and delete it, replacing it with calls to common code.
> 
> Well, introduce the damn common code first.  It does not require
> using the typedef in any way.

Already done.

> In this current form of single patches:  NAK to anything I maintain
> or review.

Yeah, we already have a plan for dealing with arsehole or MIA maintainers.
Fortunately, you're not actually the maintainer for XFS, so it'll be up
to Darrick whether to take it or not.

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux