On Mon, Apr 16, 2018 at 01:57:07AM -0700, Christoph Hellwig wrote: > On Sun, Apr 15, 2018 at 05:34:27AM -0700, Matthew Wilcox wrote: > > On Sun, Apr 15, 2018 at 05:04:26AM -0700, Christoph Hellwig wrote: > > > On Sun, Apr 15, 2018 at 04:11:04AM -0700, Matthew Wilcox wrote: > > > > > Please just send one damn patch adding the typedef and the sparse > > > > > annotation and converting everyone over. Splitting this into five > > > > > gazillion patches that do nothing doesn't help anyone. > > > > > > > > The XFS one is trivial. Many of the others are not. > > > > > > if they arne't trivial you are doing something wrong. That is you > > > fix bugs that exist independent of the annotation together with the > > > annotation. > > > > > > Fix all the bugs first, and send them in (including for -stable) and > > > then do the annotations in one big patch. > > > > They aren't all bugs. Some of them are just splitting errnos apart > > from return values for typesafety. The ones that are bugfixes are > > unlikely-to-happen bugs like running out of memory when allocating a > > page table, and returning "we inserted the PTE" instead of "we ran out > > of memory". More of a QOI issue than an exploitable bug. > > Then do all the cleanups first and do the batch rename of the type after > that, same concept. That's an unreasonable request. It would (usually) require writing more code to convert errnos into VM_FAULT returns. And that code would get precisely zero testing upstream because the next commit would come along and delete it, replacing it with calls to common code. If anybody wants to backport any of this, they should just pick up the common code (1c8f422059a "mm: change return type to vm_fault_t") and then the commit that they want. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
