Re: [PATCH] fs: xfs: Change return type to vm_fault_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 15, 2018 at 07:59:37AM +1000, Dave Chinner wrote:
> On Sun, Apr 15, 2018 at 01:35:30AM +0530, Souptick Joarder wrote:
> > Use new return type vm_fault_t for fault handlers.
> > 
> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> > Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
> 
> Ummm. Why are we adding typedefs to hide basic types?
> 
> typedef int vm_fault_t;

That's the intermediate step.  It's going to become a sparse typedef
like gfp_t once everything's converted.  And the "why" is that people
are still returning -EFOO when they should be returning VM_FAULT_FOO.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux