On Sun, Apr 15, 2018 at 12:21:21AM -0700, Christoph Hellwig wrote: > On Sat, Apr 14, 2018 at 03:24:07PM -0700, Matthew Wilcox wrote: > > On Sun, Apr 15, 2018 at 07:59:37AM +1000, Dave Chinner wrote: > > > On Sun, Apr 15, 2018 at 01:35:30AM +0530, Souptick Joarder wrote: > > > > Use new return type vm_fault_t for fault handlers. > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx> > > > > Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> > > > > > > Ummm. Why are we adding typedefs to hide basic types? > > > > > > typedef int vm_fault_t; > > > > That's the intermediate step. It's going to become a sparse typedef > > like gfp_t once everything's converted. And the "why" is that people > > are still returning -EFOO when they should be returning VM_FAULT_FOO. > > Please just send one damn patch adding the typedef and the sparse > annotation and converting everyone over. Splitting this into five > gazillion patches that do nothing doesn't help anyone. The XFS one is trivial. Many of the others are not. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
