Larry,
2011/12/11 Larry Finger <Larry.Finger@xxxxxxxxxxxx>:
> On 12/10/2011 07:55 PM, Rafał Miłecki wrote:
>>
>>
>> Signed-off-by: Rafał Miłecki<zajec5@xxxxxxxxx>
>> ---
>> drivers/net/wireless/b43/phy_n.c | 90
>> +++++++++++++++++++++++++++++++++++++-
>> 1 files changed, 88 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/phy_n.c
>> b/drivers/net/wireless/b43/phy_n.c
>> index 114c413..6e776d0 100644
>> --- a/drivers/net/wireless/b43/phy_n.c
>> +++ b/drivers/net/wireless/b43/phy_n.c
>> @@ -4023,6 +4023,58 @@ int b43_phy_initn(struct b43_wldev *dev)
>> return 0;
>> }
>>
>> [snip]
>
> My gcc is brain dead here and outputs
>
> [snip] variable may be used uninitialised warning
It's not brain dead =)
> The variable is clearly set in all paths, but I still get the warning.
It's set in all paths, but there is no way to guarantee that one of
the paths will be taken - they all have conditions.
Something like the following might be better:
>> +static void b43_nphy_pmu_spur_avoid(struct b43_wldev *dev, bool avoid)
>> +{
>> + struct bcma_drv_cc *cc =&dev->dev->bdev->bus->drv_cc;
>>
>> + u32 pmu_ctl;
>> + if (dev->dev->chip_id == 43224 || dev->dev->chip_id == 43225) {
>> [snip]
>> + } else if (dev->dev->chip_id == 0x4322 || dev->dev->chip_id ==
>> 0x4340 ||
>> + dev->dev->chip_id == 0x4341) {
>> + bcma_chipco_pll_write(cc, 0x0, 0x11100070);
>> + bcma_chipco_pll_write(cc, 0x1, 0x1014140a);
>> + bcma_chipco_pll_write(cc, 0x5, 0x88888854);
>> + if (avoid)
>> + bcma_chipco_pll_write(cc, 0x2, 0x05201828);
>> + else
>> + bcma_chipco_pll_write(cc, 0x2, 0x05001828);
>> + pmu_ctl = BCMA_CC_PMU_CTL_PLL_UPD;
+ } else {
+ B43_WARN_ON(1);
+
+ return;
+ }
+
>> + bcma_cc_set32(cc, BCMA_CC_PMU_CTL, pmu_ctl);
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
