Felix,
On Sun, Dec 11, 2011 at 08:00, Felix Fietkau <nbd@xxxxxxxxxxx> wrote:
> Many systems (e.g. embedded systems) do not have wifi modules connected to
> bluetooth modules, so bluetooth coexistence is irrelevant there. With the
> addition of MCI support, ath9k picked up quite a bit of extra code that
> can be compiled out this way.
>
> This patch redefines ATH9K_HW_CAP_MCI and adds an inline wrapper for
> querying the bluetooth coexistence scheme, allowing the compiler to
> eliminate code that uses it, with only very little use of #ifdef.
>
> On MIPS this reduces the total size for the modules by about 20k.
>
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
> ---
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> index 8599822..4905af9 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
> @@ -85,6 +85,9 @@ void ar9003_mci_remote_reset(struct ath_hw *ah, bool wait_done)
> {
> u32 payload[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 0xffffff00};
>
> + if (!ATH9K_HW_CAP_MCI)
> + return;
> +
IMHO, the checks for ATH9K_HW_CAP_MCI don't make it obvious that
they're checking whether coexistence is enabled, and are more about
whether *part* of it is enabled - which could cause confusion if
another scheme is ever added, or it gets a not-insignificant re-write.
Surely it wouldn't be too bad to do some #defining around this code
and in the headers etc. so that the coexistence only functions aren't
even looked at by the compiler if isn't enabled? IMHO putting the
btcoex code in #ifdef blocks is better documentation as it's saying
"these are the btcoex functions, and they're only used if this config
variable is enabled" not "this random function can be skipped if some
hardware feature is disabled".
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
