Search Linux Wireless

Re: [PATCH v2 2/4] ath9k_hw: clean up tx power handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-09-20 12:13 AM, Luis R. Rodriguez wrote:
On Mon, Sep 19, 2011 at 3:12 PM, Luis R. Rodriguez
<mcgrof@xxxxxxxxxxxxxxxx>  wrote:
 On Mon, Sep 19, 2011 at 3:04 PM, Felix Fietkau<nbd@xxxxxxxxxxx>  wrote:
 On 2011-09-19 11:54 PM, Luis R. Rodriguez wrote:

 On Mon, Sep 19, 2011 at 2:45 PM, Luis R. Rodriguez
 <mcgrof@xxxxxxxxxxxxxxxx>    wrote:

   On Mon, Sep 19, 2011 at 2:21 PM, Felix Fietkau<nbd@xxxxxxxxxxx>    wrote:

   I looked at the other ath driver and I see no indication that it's
 related
   to DFS in any way.

   I have verified this just now as well, it seems it was only used to
   support an ioctl to userspace to enable users to update a tpscale
   value but I see no documentation about this. Next question is who in
   usersapce sets this. I wonder if its done through userspace after
   measuring some TPC reports from STAs.

 So this comes from supporting a "TR-098" specification, which seems to
 be the "Internet Gateway Device data model for the CPE WAN Management
 Protocol". I haven't yet been able to map this to the specification
 respective component:

 http://www.broadband-forum.org/technical/download/TR-098.pdf

 Interesting. That definitely supports my point that ath9k is the wrong place
 for something like this to be. Let's just get rid of it.

 Yeah, I'm now convinced :) die code. But please do add some blurb
 about this tumor the code had.

In fact removing the tumor through a separate patch would be appreciated.
I don't think it needs a separate patch. It's dead code directly related to the other things that I'm changing, and it does not add any functional changes. I'll add a comment, though.

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux