> Of course I'd accept that Reducing duplicated code is good, and I > can deal with patches touching many files. Though it'd be nice to do the > necessary refactoring first. Ok give me some time and I'll have a look at util.c. > > A nice touch, btw, would be if you included a diffstat. Maybe you should > look at using quilt or git to submit patches which help you automate a > lot of things. Actually I don't like git, but when this is getting something bigger,I'll agree to use it :) > > But i would appreciate if you could comment on the design of the patch itself. > > Basically i just took Benoits approach and made it running. A separate option > > for setting channel_type isn't necessary. You could also tell by iw whether to > > use HT or not. Or no option at all, a module option ibss_ht etc. Or even setting > > full options as hostapd does via iw. > > I'm sorry, I don't understand what you mean by "a separate option"? With > the approach that you've posted patches for you need to tell iw whether > you want HT or not, right? What i mean is, right now there's just one option - setting the HT channel. There could be less (the card automatically enables HT and uses it for a station that advertises HT), or even more (as in hostapd.confs HT section). Or there could be a module option to switch ht for ibss on or off. So, i'm asking about the "ideal" interface... -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
