Johannes Berg <johannes@...> writes: > > On Thu, 2011-01-20 at 09:10 +0000, Alexander Simon wrote: > > > What do you mean with a "not so refactoring version"? I am adding a new IE. > > These are only insertions, no other changes. Or do you mean that dev_alloc_skb? > > However, i took the last "try" from Benoit. > > Well, then maybe I just discussed this with him -- there's similar code > building the HT IEs for stations, that code should be shared. So you mean my patch 2/4? It could work but you would have to change util.c of course. I was pretty sure you wouldn't have accepted that. > Yes all of that might be necessary, but can you post patches that do one > thing at a time? Like at least one cfg80211/nl80211 patch that adds the > configurability, and then a mac80211 patch that will use it. > > Also, I think cfg80211 should support advertising to userspace that it's > supported. > > Yes, I sometimes accept combined cfg80211/mac80211 patches, but I think > this feature is bigger than that. Ok, separating cfg from mac. No big deal. I'll have to look how to advertise something... But i would appreciate if you could comment on the design of the patch itself. Basically i just took Benoits approach and made it running. A separate option for setting channel_type isn't necessary. You could also tell by iw whether to use HT or not. Or no option at all, a module option ibss_ht etc. Or even setting full options as hostapd does via iw. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
