2010/11/1 Björn Smedman <bjorn.smedman@xxxxxxxxxxx>: > 2010/11/1 Bob Copeland <me@xxxxxxxxxxxxxxx>: >> late-comers know which data is serialized by the barrier. In the best >> case, said late-comers are more knowledgeable than me and fix the crap >> code that I write. > > First let me apologize for the tone in my previous mail. It came out > too hard this Monday (due to a long and unwanted weekend of debugging > ath9k DMA errors). I did not mean to suggest that any code is crap > regardless of origin (except maybe if I wrote it). Err, no worries, I don't think anyone took it that way (I don't do much ath9k stuff anyway). I literally meant my own code is often crap so I try to leave breadcrumbs for people, esp for nitpicky things like barriers :) > Thanx Bob for your input. If we agree the memory barriers are needed > for correctness I will add comments and post as PATCH. Sure, my opinion may not matter for ath9k, but I think it is a good idea. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
