On Thu, Oct 28, 2010 at 4:45 PM, Felix Fietkau <nbd@xxxxxxxxxxx> wrote: > On 2010-10-29 1:36 AM, Ben Greear wrote: >> On 10/09/2010 08:23 AM, Felix Fietkau wrote: >>> On 2010-10-09 5:19 PM, BjÃrn Smedman wrote: >>>> On Tue, Oct 5, 2010 at 9:50 PM, Luis R. Rodriguez >>>> <lrodriguez@xxxxxxxxxxx> Âwrote: >>>>> Felix is more familiar with this area so I'll let him chime with >>>>> his ACK/NACK. >>>>> >>>>> Â Luis >>>> >>>> So Felix, what do you think? I realize it may not be a common problem >>>> on any currently popular platform, but don't you agree it is in >>>> principle unsafe to write to the ds_link field of dma descriptors >>>> without a guarantee that those writes will be performed in the >>>> intended order? >>> Haven't had time to review this in detail yet. I'll take another look at >>> it later... >> >> Had a chance to look at it? ÂI've been carrying this in my >> tree and it hasn't caused any obvious problems, for what that's >> worth... > Not sure if the patch helps with anything, but I think it can go in... I'd rather not add it if its not fixing anything. I hate code that is there just because we have a fuzzy feeling it helps. So NACK unless it fixes something. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html