On Fri, Oct 29, 2010 at 2:57 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: [snip] > I'd rather not add it if its not fixing anything. I hate code that is > there just because we have a fuzzy feeling it helps. > > So NACK unless it fixes something. > > Luis IMHO there is a right and wrong, at the very least inside a computer. If we can't read the documentation (Documentation/memory-barriers.txt) and decide if the patch is correct or incorrect (I'm not saying I can with 100% certainty) then perhaps we should ask somebody who can? BTW, I also hate code that is there just because somebody has a fuzzy feeling it helps. We definitely don't need more of that. But I do like code that is correct in principle, code that I can change and get a predictable result. Code that works most of the time on most platforms (as long as I don't make any changes) is no friend of mine. /Björn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
