Johannes Berg wrote:
On Wed, 2010-05-26 at 00:54 +0200, Gábor Stefanik wrote:
- if (wdev)
- wdev->channel = chan;
+ wdev = old_wdev;
+ wdev->channel = chan;
NACK. That will crash when there really is no interface being passed in.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Well, the original version already dereferences wdev in "if
(wdev->iftype...", so the crash is nothing new if it exists.
It has also been fixed since.
Can someone port this patch up so it includes the fix Johannes is
speaking of? Kind of craptastic to have not one but TWO bugs which
completely break monitor mode AND channel hopping. If we fix both at
once we can have a working driver :-) I have plenty of testers standing by.
Thanks,
Rick
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
