On Wed, 2010-05-26 at 15:27 +0200, ext Johannes Berg wrote: > On Wed, 2010-05-26 at 16:13 +0300, Juuso Oikarinen wrote: > > > > > diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c > > > > index b2cc1fd..0b8360c 100644 > > > > --- a/net/mac80211/ibss.c > > > > +++ b/net/mac80211/ibss.c > > > > @@ -529,7 +529,8 @@ static void ieee80211_sta_create_ibss(struct ieee80211_sub_if_data *sdata) > > > > sdata->drop_unencrypted = 0; > > > > > > > > __ieee80211_sta_join_ibss(sdata, bssid, sdata->vif.bss_conf.beacon_int, > > > > - ifibss->channel, 3, /* first two are basic */ > > > > + ifibss->channel, > > > > + 15, /* 1, 2, 5.5 and 11 are basic */ > > > > > > It's still wrong for 5 GHz. > > > > Yes, it is as wrong for 5GHz as it was before the change. > > No it wasn't wrong before the change, and only the comment is now > wrong ... > > before the change, 6 and 9 mbps were basic for 5ghz, now it would be > 5,9,12 and 18. Neither set actually overlaps with the mandatory rates, > which is a bug I guess? Ah, now I get it. So the rate bitmap changes - I had a confusion here. > > > We've had this discussion before. Making more rates required will break > > > compatibility with 11b devices. > > > > I don't understand this. AFAIK also in 11b all these rates are > > mandatory. How come this breaks 11b? > > No, only 1mbit is really mandatory in 11b. So I guess our default should > be just "1" rather than "3" or something like that. That's weird. At least in certification PoV, AFAIK, a device would not pass with just 1mbit even for 11b. > > This change is for creating IBSS, not joining. In case of joining, we > > still adhere to the basic rates set by the creator, or that is what I > > understand based on the code. > > > > > What should be done here is add a basic rates parameter to the IBSS join > > > nl80211 command so that you can decide at runtime which rates to use as > > > basic. > > > > Yeah, this is a solution needed latest when 5GHz support is implemented. > > Well this hopefully doesn't come as a surprise to you, but mac80211 does > support 5 GHz operation :) Yeah, I know there is support (even the wl1271 has preliminary) but there are also some issues ;) So it seems to me that if we want this fixed, we would have to go with an interface update? > johannes > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
